-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organized notification test cases #14436
Conversation
# Conflicts: # tests/Feature/Notifications/AssetWebhookTest.php
This pull request has been linked to Shortcut Story #24901: Organize tests around notifications. |
PR Summary
|
Description
This PR focuses on notification test organization and clean ups.
I took the following files that contained tests for notifications around check ins and checkouts for their respective checkoutable:
tests/Feature/Notifications/AccessoryWebhookTest.php
tests/Feature/Notifications/AssetWebhookTest.php
tests/Feature/Notifications/ComponentWebhookTest.php
tests/Feature/Notifications/ConsumableWebhookTest.php
tests/Feature/Notifications/LicenseWebhookTest.php
and split their tests across the following files:
tests/Feature/Notifications/Email/EmailNotificationsUponCheckinTest.php
tests/Feature/Notifications/Webhooks/SlackNotificationsUponCheckinTest.php
tests/Feature/Notifications/Webhooks/SlackNotificationsUponCheckoutTest.php
(Note that the "Webhook" has been replaced with "Slack" since that is what is actually being tested)
Along the way I created improved a helper method name (
disablesSlackWebhook()
), added a helper trait (AssertsAgainstSlackNotifications
), and added agroup notifications
annotation to these test classes.Type of change