Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Labels: bulk actions are handled before sorting #14375

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Mar 5, 2024

Description

This moves the bulk actions to the top of the stack and the sorting overrides to the bottom. Data was getting tangled when sorted first and then sent to the label engine. the scopeFooOrder would replace the the asset->ids with the Foo->ids instead potentially. So, if your last sort (that worked) was locations, asset.name would be location.name, asset.id for qrcodes would actually be the location.id causing bad links. None of that sorting manipulation is required for labels.

It was rough coming to this conclusion. But here we are lol.

Fixes #SC-24941 FD-40486

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Mar 5, 2024

PR Summary

  • Removal of Old Asset Sorting Method
    The previous code used for sorting our digital assets based on varying criteria has been removed. This part of the code may have been affecting our system's efficiency and performance.

  • Introduction of New Asset Sorting Method
    A new method to sort our digital assets has been instated. This change improves the ways our resources are organized, thereby enhancing user experience by allowing quicker and more accurate access to necessary resources.

@Godmartinz Godmartinz changed the title bulk actions are handled before sorting Fixed Labels: bulk actions are handled before sorting Mar 6, 2024
@bzeus
Copy link
Collaborator

bzeus commented Mar 6, 2024

Looks good!

@snipe snipe merged commit 4f883b1 into snipe:develop Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants