Fixed Labels: bulk actions are handled before sorting #14375
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the bulk actions to the top of the stack and the sorting overrides to the bottom. Data was getting tangled when sorted first and then sent to the label engine. the scopeFooOrder would replace the the asset->ids with the Foo->ids instead potentially. So, if your last sort (that worked) was locations, asset.name would be location.name, asset.id for qrcodes would actually be the location.id causing bad links. None of that sorting manipulation is required for labels.
It was rough coming to this conclusion. But here we are lol.
Fixes #SC-24941 FD-40486
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: