-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds quantity of accessories and consumables to checkout. #14342
base: develop
Are you sure you want to change the base?
Conversation
This pull request has been linked to Shortcut Story #9899: Checkout multiple consumables/accessories at once. |
PR Summary
|
app/Http/Controllers/Consumables/ConsumableCheckoutController.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped in to check out the test failures and have some comments. Some small changes needed but almost there 👍🏾
app/Http/Controllers/Accessories/AccessoryCheckoutController.php
Outdated
Show resolved
Hide resolved
adds corrections, error messages
…ability/snipe-it with conflicts.
…-9899 # Conflicts: # app/Http/Controllers/Accessories/AccessoryCheckoutController.php # app/Http/Controllers/Consumables/ConsumableCheckoutController.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@snipe all good here? |
Hey, this would be really neat, can we expect it to be merged before v7 or only after the big version bump? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Problem her is one thing. When sending an email of assigned consumables and or any, it will list all the items with the same name and category all the way down.
For Example: if there is 200 Pen assigned to one person it is sending 200 pen listed all the way down.
Is there any fix for this? Like putting Name of Consumable and Qty only ratherthan repeating the list of same item in email.
Description
This allows for users to checkout multiple Accessories and Consumables of the same type at the same time.
Only one email is sent with a quantity listed.
The action log still logs each accessory or consumable checked out.
Checkins for accessories remains singular.
Fixes #7348
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: