-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update snipeit.sh for v7 Requirements #14105
Conversation
because "$@" splits positional parameters, but quoting the args makes them one arg, which doesn't work
since 2023 didn't produce and LTS ubuntu versions the Ondrej repo we use for installing arbitrary PHP versions doesn't (easily) support non-LTS versions of ubuntu, which means that 23.04 and 23.10 are problematic using the repo However, these versions ship with php8.1 and php8.2 (respectively), so we don't even need the Ondrej repo for these, so we'll remove it In general, we'll only support LTS Ubuntu repos because of this, but if they happen to ship with our preferred PHP versions and otherwise work w/o heroics, we'll include nominal support in the script
different vim config confusion made my regex misbehave :-/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks excellent! Thank you so much for all of your very hard, detailed work on this - but I love the idea that we can install more 'cleanly' on Snipe-IT v7 going forward with all of this work. I did see one thing that had a 'jerm' in it that I wanted to double-check is actually an OK thing to have, and I would love it if it were possible to potentially re-integrate Fedora support, perhaps for a later V7.x version. But once we've cleared that up I'll be happy to integrate it all! Thanks again for your painstaking work on this - it couldn't have been easy, and is just so heavily detail-focused - I don't think I would've been able to do it. If you can let me know about those questions we'll get this merged in ASAP. Thank you!!!
using master until we make the switch to main. As master will keep working after we switch branches, main will _not_ work _until_ we switch, and if for some reason we have to delay the branch migration, this will remain broken until we fix it.
update changelog
update snipeit DB user name to not collide with database name
remove Fedora surpport, add amazoni linux 2 and Alma 8/9
Add php8.2 support in centos/alma
Split apart mysql user creation and permissions grant. Can't do them
as one operation anymore
In general, we'll only support LTS Ubuntu repos because of this, but if
they happen to ship with our preferred PHP versions and otherwise work w/o
heroics, we'll include nominal support in the script
the Ondrej repo we use for installing arbitrary PHP versions doesn't
(easily) support non-LTS versions of ubuntu, which means that 23.04 and
23.10 are problematic using the repo
However, these versions ship with php8.1 and php8.2 (respectively), so we
don't even need the Ondrej repo for these, so we'll remove it
split-out ubuntu 23* versions
since 2023 didn't produce and LTS ubuntu versions
remove remaining 8.2 references in Ubuntu 23* block, because they
ship with new-enough php (for now.. see below)
update Ubuntu versions comment in code block
stop quoting run_as_app_user args
because "$@" splits positional parameters, but quoting the args makes them
one arg, which doesn't work
fix up ondrej repo
add new ubuntu/debian versions, change php to 8.2