Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused files in assets directory #14063

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR removes unreferenced files from the /resources/assets/ directory. These files are all sourced from third party libraries and were either copy/pasted from node_modules or from GitHub and added to version control.

"unreferenced" means they are not being referenced in our webpack.mix.js file and their removal doesn't cause any build errors.

Type of change

Please delete options that are not relevant.

  • Let's call it "repository clean up"

Copy link

Copy link

what-the-diff bot commented Dec 19, 2023

PR Summary

  • Removal of Component Styling Files
    The team has deleted several CSS files that were responsible for styling various components (ex: tables, date pickers, wysiwyg editor). This means the look and feel of these components might change.

  • Removal of Font Files
    Several files that provided font resources for FontStyle icons have been removed from our system. This means we might see some changes in the icons used within the application.

  • Deletion of Locale Files for Bootstrap Table
    Numerous locale files for a Bootstrap table component were deleted. These files contained translations for the component in several different languages.

  • Deletion of Scripts
    Some JavaScript files (dashboard.js, dashboard2.js, bootstrap-table-cookie.min.js, and others) have been removed. These scripts could have had various functionalities in our application, so we might notice some changes in our app's behavior.

  • Removal of LESS Files
    Several LESS files, that determined the styles for various UI elements (like boxes, buttons, headers, navs etc.) have been deleted. This will possibly impact the appearance of these elements in the system.

Please note that these deletions might be part of a broader restructuring or redesign effort. Make sure to check out our latest app version to see the changes in action.

@marcusmoore
Copy link
Collaborator Author

@uberbrady forgot to tag you for a review (since you've been managing the v7 branch)

@marcusmoore
Copy link
Collaborator Author

@snipe I just checked and we're still able to do exports (I checked assets) via the table menu:
image

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made sure to blow out my ./node_modules directory, did a fresh npm install and made sure to make production assets, then click around. Everything seemed to work fine!

@snipe snipe merged commit d29b363 into snipe:snipeit_v7_laravel10 Jan 4, 2024
6 checks passed
@marcusmoore marcusmoore deleted the chore/sc-24353 branch January 4, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants