Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added strtolower for category type #13333

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 19, 2023

This fixes an issue where if data was inserted into the category table for category_type but was uppercased, it would fail. This lowercases the comparison. (I'm still trying to figure out how that data would get in there that way - API maybe?)

@snipe snipe merged commit dc20305 into develop Jul 19, 2023
4 checks passed
@snipe snipe deleted the fixes/strtolower_on_catgories branch July 19, 2023 08:00
@what-the-diff
Copy link

what-the-diff bot commented Jul 19, 2023

PR Summary

  • Modification of if condition in Helper.php
    The logic for determining the selected category has been altered. Previously, matching was case sensitive which could cause mismatches and errors. Now, the user's input is converted to lowercase before selecting the corresponding category. This change will ensure more consistent behavior across the system regardless of user input case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant