Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: deleted users showing in current users #13311

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 14, 2023

This should fix FD-36808, FD-36813 and SC-23479. It simply moves the deleted requirement down further in the query stack.

@what-the-diff
Copy link

what-the-diff bot commented Jul 14, 2023

PR Summary

  • Refactored User Handling Method
    The flow of how users are handled in the UsersController.php file has been optimized. The ordering of conditions for managing both deleted and undetleted users have been modified for better performance and clarity.

@snipe snipe merged commit 15bb943 into develop Jul 14, 2023
3 checks passed
@snipe snipe deleted the fixes/deleted_users_showing_in_current_users branch July 14, 2023 06:47
marcusmoore added a commit to marcusmoore/snipe-it that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant