Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added date range for EOL in custom reports #13291

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Jul 11, 2023

Description

This PR adds the End of Life column and End of Life Date filter to the Custom Asset Report:

The column displays the end of life date for an asset. The filter allows a user to select the date range of end of life assets they wish to see.

Screenshot 2023-08-02 at 4 45 17 PM

Type of change

  • New feature (non-breaking change which adds functionality)

This addresses feature request #6915

…g. otherwise the columns are either blank or another value like expected checkin i was using to test a bit
@what-the-diff
Copy link

what-the-diff bot commented Jul 11, 2023

PR Summary

  • Adding asset filtering based on EoL date in ReportsController
    In our ReportsController, we've implemented a new filtering condition. This will allow us to filter out assets based specifically on their 'End of Life' (EoL) dates. This enhances our search capabilities, making the reporting process more streamlined and accurate.

  • UI changes in Custom Blade
    Several updates have been made to our user interface file, custom.blade.php. These include:

    • Changing label for EoL date
      We've updated the label related to the EoL date. Now it reflects a more accurate descriptor, making it easier for users to understand its purpose.

    • New section for EoL date range selection
      A new section was added that allows users to select a range for the EoL date. This will further aid in detailed and focused searching.

    • Adding datepicker for EoL date range input
      We've implemented a datepicker functionality for the EoL date range input field in the front-end. This provides our users with a more intuitive and user-friendly way to input their search terms.

Through these changes, we aim to provide a more user-friendly interface, with improved and enhanced search and reporting functionalities.

@snipe snipe changed the title eol date range for reports. WIP WIP: Added date range for EOL in custom reports Jul 12, 2023
@snipe snipe marked this pull request as draft July 12, 2023 16:16
@akemidx
Copy link
Collaborator Author

akemidx commented Jul 26, 2023

no longer breaks, but just need to get the date picker working correctly, and should be good to go.

@akemidx akemidx changed the title WIP: Added date range for EOL in custom reports Added date range for EOL in custom reports Aug 2, 2023
@akemidx
Copy link
Collaborator Author

akemidx commented Aug 2, 2023

This is good to go. EoL Date is now a selectable column, AND you can choose the range of dates with a date picker on the right.

@akemidx akemidx marked this pull request as ready for review November 21, 2023 21:07
@akemidx
Copy link
Collaborator Author

akemidx commented Nov 29, 2023

Check slack thread for more discussion. This shouldn't affect how EoL is stored/calculated/etc, or the work done by others. It only reads whatever is in that column for each asset when running a custom report.

@spencerrlongg spencerrlongg self-assigned this May 29, 2024
@spencerrlongg spencerrlongg self-requested a review May 29, 2024 19:21
@akemidx
Copy link
Collaborator Author

akemidx commented Sep 9, 2024

pinging this for an updated review

@snipe snipe merged commit 8270947 into snipe:develop Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants