-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk Consumable Checkout #13062
Bulk Consumable Checkout #13062
Conversation
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
Yes, exactly, waiting for the approval of committing. |
Hello, any new on this ? Really need too. |
Hi @ak-piracha I suspect the issue lies in the way you handle the code. You seem to be using a for loop to check out from 1 to the quantity entered by the user. |
This also relates to my issue on #13587 We don't need to check out that many items but still in the 100's. I also suggested that Under the selection of user, put a Quantity you want to checkout. The quantity selector will only let you select up to the current quantity that is available. |
This is a duplicate to pull request #10842. |
thanks |
$consumable->users()->attach($consumable->id, [ | ||
'consumable_id' => $consumable->id, | ||
'user_id' => $admin_user->id, | ||
'assigned_to' => e($request->input('assigned_to')), | ||
'note' => $request->input('note'), | ||
]); | ||
|
||
} | ||
event(new CheckoutableCheckedOut($consumable, $user, Auth::user(), $request->input('note'))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not passing qty here here in the event though - it will show a checkout, but not the amount that was checked out.
Description
This PR implements the 'bulk checkout' feature for consumable items in the inventory management system. This feature allows users to check out multiple units of a consumable item at once, instead of checking out one item at a time. It addresses feature request #12892 and is motivated by the need to streamline and improve the efficiency of the checkout process. Screenshots are provided in the related issue thread.
Before:
![image](https://private-user-images.githubusercontent.com/88882041/239745774-75da0ca2-56d7-41e5-8e61-49f6cf4eaa17.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxNTEzNTgsIm5iZiI6MTcyMDE1MTA1OCwicGF0aCI6Ii84ODg4MjA0MS8yMzk3NDU3NzQtNzVkYTBjYTItNTZkNy00MWU1LThlNjEtNDlmNmNmNGVhYTE3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA1VDAzNDQxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYyZDBmM2ZlYmIwOWVlYzBiMDA5OTVjM2Q4Njg2MmE4NTFjMmU4NGRiNDVjNGI0ZjNmNTZkZmI5OWY2NzE4NmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.UI5AZZ4RS5WGgwMG9oYeQ_mwUBgmUQ4zHZrfE56jV18)
After:
![image](https://private-user-images.githubusercontent.com/88882041/239564825-d04eee51-90da-4bdf-b695-e62100f18658.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxNTEzNTgsIm5iZiI6MTcyMDE1MTA1OCwicGF0aCI6Ii84ODg4MjA0MS8yMzk1NjQ4MjUtZDA0ZWVlNTEtOTBkYS00YmRmLWI2OTUtZTYyMTAwZjE4NjU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA1VDAzNDQxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ1ZWQ2NDQ1M2FjNzEyYTI2YTQxMzNiN2FjNjg0ZjFmODY1OGMyNjJmMmFmYWVhMTg1MWNjMTVhYmIxZTFjNDkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.loID-Ic1MCBxm8S-RSRVmjLvPFgfEXNLilTeL9LHudU)
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This feature has been tested manually, following these steps:
Test Configuration:
Checklist: