Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mismatched field/fieldset #12474

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Fixed mismatched field/fieldset #12474

merged 1 commit into from
Feb 7, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Feb 7, 2023

Thanks to a passive-aggressive comment on a PR, we discovered a regression that this should fix.

@snipe snipe requested a review from uberbrady as a code owner February 7, 2023 21:33
@snipe snipe merged commit 4b2d35e into develop Feb 7, 2023
@what-the-diff
Copy link

what-the-diff bot commented Feb 7, 2023

  • The CustomFieldset model is now used instead of the CustomField model.

@snipe snipe deleted the fixes/destroy_method_for_fieldsets branch February 7, 2023 21:33
@snipe snipe mentioned this pull request Feb 7, 2023
Closed
@busseyjm
Copy link

busseyjm commented Feb 7, 2023

I had no intention of sounding passive-aggressive, my apologies.

@snipe
Copy link
Owner Author

snipe commented Feb 7, 2023

All good. Thanks for trying to help. 👍🏻

@snipe snipe mentioned this pull request Feb 21, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uberbrady uberbrady Awaiting requested review from uberbrady uberbrady is a code owner

Assignees
No one assigned
Labels
backend custom fields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snipe @busseyjm