Fixed: Checkin limit string translation for components

[akemidx]

Description

Translating the string informing users of the limit to how many components can be checked in.

• Bug fix (non-breaking change which fixes an issue)

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

• Added a new line to the language file
• Changed an existing line in the view file

[snipe]

Small clarification that I'd like to see, but not a hill I'll die on. Let me know if you're interesting in switching it to a variable, otherwise I'll take it as is :)

[snipe]

This would be a great place to use a variable. Our implementation in the blade is - sub-optimal (and that's my fault), because different languages might be represent values in different parts of a sentence.

Something like:

'checkin_limit' => 'Amount checked in must be equal to or less than :assigned_qty

and then in the blade change (below) something like:

{{ trans(admin/components/general.checkin_limit, ['assigned_qty' => '$component_assets->assigned_qty']) }}

It's a minor detail, but comes across a little "friendlier".

[akemidx]

yea, that's an easy change! Something like this will pop up in other places and future PRs as well

[snipe]

Looks like we still need enclosing apostrophes here tho:

{{ trans(admin/components/general.checkin_limit, ['assigned_qty' => '$component_assets->assigned_qty']) }}

should be

{{ trans('admin/components/general.checkin_limit', ['assigned_qty' => '$component_assets->assigned_qty']) }}

The key we present in the trans() bit should always be enclosed in apostrophes.

[snipe]

And actually we wouldn't need them enclosed with the variable part.

{{ trans('admin/components/general.checkin_limit', ['assigned_qty' => $component_assets->assigned_qty]) }}

When we're passing a variable, enclosing it on quotes will cause it to return the literal string of $component_assets->assigned_qty, instead of the value of $component_assets->assigned_qty.

[snipe]

Looks great, thanks!!