Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixesArgument 1 passed to App\Http\Requests\ItemImportRequest::import() must be an instance of App\Models\Import, null given #11147

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented May 18, 2022

Description

When processin an Import, we make a search for a record in the DB of an Import entity. If, for some reason that record isn't found the system crashes. I put an early return if the entity is not found, so it returns an error instead of just crash without give useful feedback to the user.

Fixes rollbar 16130

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 7.4.16
  • MySQL version: 8.0.23
  • Webserver version: nginx/1.19.8
  • OS version: Debian 10

Checklist:

@inietov inietov requested review from uberbrady and snipe May 18, 2022 11:22
@snipe snipe merged commit b426fa3 into snipe:develop May 18, 2022
@snipe
Copy link
Owner

snipe commented May 18, 2022

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants