Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In bulk users edit, language defaults to admin interface language #15504

Closed
2 tasks done
swift2512 opened this issue Sep 13, 2024 · 1 comment
Closed
2 tasks done

In bulk users edit, language defaults to admin interface language #15504

swift2512 opened this issue Sep 13, 2024 · 1 comment

Comments

@swift2512
Copy link

Debug mode

Describe the bug

In bulk users edit screen, language field is prefilled with language of admin interface.

Reproduction steps

  1. Set app_locale to german (or anything other than English)
  2. Set language for all users to German.
  3. Set language for admin to English.
  4. Select multiple users and do 'Bulk Edit'
    R: Language field is prefilled with admins interface language.
    (If this form is saved, for all users language is changed to English)

Expected behavior

Language field should be empty like some other fields. If admin doesn't select language from the list - language field is not touched in the database.

Screenshots

image
image

Snipe-IT Version

7.0.12

Operating System

Ubuntu

Web Server

Apache

PHP Version

8.3

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

As admin, I use English interface, but majority of users use Lithuanian. While adding City information to their profiles, I unintentionally changed their interface language to English because this field was prefilled. To avoid language change, I have to manually change English to Lithuanian every single time. What makes this matter even worse, in our organization we have employees who use Snipe-IT in languages, other than English or Lithuanian.

snipe added a commit that referenced this issue Sep 16, 2024
Fixed #15504 - allow nulling/not changing locale in user bulk edit
@snipe snipe closed this as completed in 4debaae Sep 16, 2024
@snipe
Copy link
Owner

snipe commented Sep 16, 2024

Thanks! Niche bug, but you're good at finding those :) Fix is on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants