Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ability to disable profile pics #15015

Closed
designatedsuccessor opened this issue Jul 3, 2024 · 4 comments
Closed

[Feature Request]: Ability to disable profile pics #15015

designatedsuccessor opened this issue Jul 3, 2024 · 4 comments

Comments

@designatedsuccessor
Copy link

Is your feature request related to a problem? Please describe.

SCIM does not currently support provisioning user profile pics from an IdP, so we have no use for profile images. So every user profile has a smiley-face image for no reason.

Describe the solution you'd like

The ability for admins to completely disable profile pictures. That would eliminate the default smiley-face image, like this one:
image
Right now, the image just taking up space for no reason in our environment.

It appears to also be beside the user's name in the upper-right corner.

Describe alternatives you've considered

No response

Additional context

No response

@snipe
Copy link
Owner

snipe commented Jul 3, 2024

I don't really see why we'd need to do that though. They're just smiley faces. What harm do they cause? The amount of code changes we'd have to make for this doesn't really seem worth it to me.

@designatedsuccessor
Copy link
Author

designatedsuccessor commented Jul 3, 2024

I don't really see why we'd need to do that though. They're just smiley faces. What harm do they cause? The amount of code changes we'd have to make for this doesn't really seem worth it to me.

It's just weird and users ask why there is a smiling face pic in their profile (they don't understand that it is a profile pic).

If you want to reduce code complexity, rip out all the profile image code for all I care. I think it adds little value for the majority of organizations and raises unnecessary questions in other orgs.

Another option: add a CSS class attribute to all profile pics, and then orgs can use custom CSS to do a { display : none; } on them.

@snipe
Copy link
Owner

snipe commented Jul 4, 2024

rip out all the profile image code for all I care. I think it adds little value for the majority of organizations and raises unnecessary questions in other orgs.

That's definitely not true, based on my experience running this project for 11+ years.

It's not just you we have to care about here.

@designatedsuccessor
Copy link
Author

rip out all the profile image code for all I care. I think it adds little value for the majority of organizations and raises unnecessary questions in other orgs.

That's definitely not true, based on my experience running this project for 11+ years.

It's not just you we have to care about here.

Right. In any case, if the profile elements can get a unique class attribute added, we can remove them via CSS while the folks you think use it can happily continue doing so.

snipe added a commit that referenced this issue Jul 4, 2024
…vatar

Added #15015 - ability for admins to select default avatar
@snipe snipe closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants