Skip to content

Commit

Permalink
Add tests for delete departments endpoint
Browse files Browse the repository at this point in the history
  • Loading branch information
marcusmoore committed Sep 16, 2024
1 parent 3105f53 commit 38b9f4a
Show file tree
Hide file tree
Showing 3 changed files with 70 additions and 1 deletion.
5 changes: 5 additions & 0 deletions database/factories/UserFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,11 @@ public function checkoutConsumables()
return $this->appendPermission(['consumables.checkout' => '1']);
}

public function deleteDepartments()
{
return $this->appendPermission(['departments.delete' => '1']);
}

public function viewDepartments()
{
return $this->appendPermission(['departments.view' => '1']);
Expand Down
1 change: 0 additions & 1 deletion tests/Feature/Companies/Api/DeleteCompaniesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Tests\Feature\Companies\Api;

use App\Models\Asset;
use App\Models\Company;
use App\Models\User;
use Tests\Concerns\TestsPermissionsRequirement;
Expand Down
65 changes: 65 additions & 0 deletions tests/Feature/Departments/Api/DeleteDepartmentTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
<?php

namespace Tests\Feature\Departments\Api;

use App\Models\Company;
use App\Models\Department;
use App\Models\User;
use Tests\Concerns\TestsMultipleFullCompanySupport;
use Tests\Concerns\TestsPermissionsRequirement;
use Tests\TestCase;

class DeleteDepartmentTest extends TestCase implements TestsMultipleFullCompanySupport, TestsPermissionsRequirement
{

public function testRequiresPermission()
{
$department = Department::factory()->create();

$this->actingAsForApi(User::factory()->create())
->deleteJson(route('api.departments.destroy', $department))
->assertForbidden();
}

public function testCanDeleteDepartment()
{
$department = Department::factory()->create();

$this->actingAsForApi(User::factory()->deleteDepartments()->create())
->deleteJson(route('api.departments.destroy', $department))
->assertStatusMessageIs('success');

$this->assertDatabaseMissing('departments', ['id' => $department->id]);
}

public function testAdheresToMultipleFullCompanySupportScoping()
{
[$companyA, $companyB] = Company::factory()->count(2)->create();

$departmentA = Department::factory()->for($companyA)->create();
$departmentB = Department::factory()->for($companyB)->create();
$departmentC = Department::factory()->for($companyB)->create();

$superUser = $companyA->users()->save(User::factory()->superuser()->make());
$userInCompanyA = $companyA->users()->save(User::factory()->deleteDepartments()->make());
$userInCompanyB = $companyB->users()->save(User::factory()->deleteDepartments()->make());

$this->settings->enableMultipleFullCompanySupport();

$this->actingAsForApi($userInCompanyA)
->deleteJson(route('api.departments.destroy', $departmentB))
->assertStatusMessageIs('error');

$this->actingAsForApi($userInCompanyB)
->deleteJson(route('api.departments.destroy', $departmentA))
->assertStatusMessageIs('error');

$this->actingAsForApi($superUser)
->deleteJson(route('api.departments.destroy', $departmentC))
->assertStatusMessageIs('success');

$this->assertNotNull($departmentA->fresh(), 'Department unexpectedly deleted');
$this->assertNotNull($departmentB->fresh(), 'Department unexpectedly deleted');
$this->assertNull($departmentC->fresh(), 'Department was not deleted');
}
}

0 comments on commit 38b9f4a

Please sign in to comment.