Delegate authorization from groups.$DOMAIN to $DOMAIN #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horazont
force-pushed
the
feature/delegate-authz
branch
2 times, most recently
from
70bf19d to
e6bfde8
Compare
This allows us to set the avatar of circles both from the app and from the web portal (with snikket-web-portal#150). However, this also makes all admins owners in all circles. This may be problematic, or may not be. The upside is that it also automatically allows managing the avatar through the apps. The downside is that it exposes a bunch of dangerous controls (banning, kicking) which desyncs the group membership from MUC membership. We might want a reconciliation loop for that, or figure out something else which overrides outcast-ness or forbids banning or stuff like that, *or* which alternatively reflects that change in the circle UI.
With mod_authz_delegate (see parent commit), all Snikket admins are now owners in all circle MUCs (and non-circle MUCs, for that matter). This implies that they're able to change affiliations. As that is a footgun which may cause desyncs between the circle state and the MUC membership list, we block both invites and affiliation changes, unless triggered by code.
horazont
force-pushed
the
feature/delegate-authz
branch
from
e6bfde8 to
0e2b7fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to set the avatar of circles both from the app and from
the web portal (with snikket-web-portal#150).
However, this also makes all admins owners in all circles. To mitigate the potential unfortunate side-effects, affiliation changes (both direct and indirect through invites) are blocked, unless caused by prosody code.