Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated constants with imports from ClimateEntity. #16

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

pmackey2
Copy link
Collaborator

This PR replaces deprecated constants with their modern equivalents from ClimateEntity.

  • Replaced SUPPORT_* constants (e.g., SUPPORT_PRESET_MODE, SUPPORT_FAN_MODE, SUPPORT_TARGET_TEMPERATURE) with ClimateEntityFeature enums.
  • Updated HVAC_MODE_* constants to use the HVACMode enum.
  • Replaced CURRENT_HVAC_* constants with HVACAction enums.
  • Updated TEMP_CELSIUS to UnitOfTemperature.CELSIUS.

@snikch
Copy link
Owner

snikch commented Jan 31, 2025

Thanks @pmackey2!

@snikch snikch merged commit c45ad82 into snikch:master Jan 31, 2025
@snikch
Copy link
Owner

snikch commented Jan 31, 2025

@pmackey2 if I make you a collaborator, will you cut a new GH release?

@pmackey2
Copy link
Collaborator Author

Sure, I can give that a go.

Other than the version bump in the manifest, does anything need to be done for the release to be picked up in HACS?

@snikch
Copy link
Owner

snikch commented Jan 31, 2025

@pmackey2 I'm not 100% sure, @SgtBatten did it last time - I'd only ever installed manually.

I see there's also a Github release, so possibly adding a new git tag and generating a release associated to it is required too. I'd recommend v1.1.0.

I've made you a collaborator, thanks for your help on this 👌

@SgtBatten
Copy link
Collaborator

Jeez, and i haven't done one since, but it shouldn't be much to get hacs to pick it up

@SgtBatten
Copy link
Collaborator

Seems to have worked. Hacs should pick it up within 24 hours and notify people in he updates section.

@pmackey2
Copy link
Collaborator Author

pmackey2 commented Feb 3, 2025

Well, I found that both HACS check actions had been disabled because there were no repo updates for sixty days. I've enabled them and they have both failed, so it seems there is some further remediation to do.

One of the tasks is to register Escea as a brand in the home-assistant repo. I'll take a look into what's involved. It looks simple enough.

@pmackey2
Copy link
Collaborator Author

So it looks like there is now an Escea integration in Home Assistant Core: code and documentation.

I haven't yet tested it, but it claims to support DF, DL, DS, and DX fireplaces.

I couldn't update the brand stuff because of this other integration (which is how I discovered it). There might be a way around it, but given the maturity of this other integration, I'm not sure if that is best.

@snikch
Copy link
Owner

snikch commented Feb 11, 2025

It seems unnecessary to have two different options for end users. If there's an integration in core which is more mature than this one, it might be worth advising users to migrate to that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants