Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both HTTP1 and HTTP2 already streamed internally,
this PR simply moves the stream out.
This PR also changed the main Finch API to have a
explicit step that builds the request. Instead of:
You must now do:
This is necessary otherwise the
Finch.stream/5
API would be very complex. One advantage of this
approach is also that we no longer need to pass
empty headers when configuring get requests, for
example, instead of:
One can now write:
The previous API has been properly deprecated.
Finally, this PR streamlines the
receive_timeout
value. Previously the documentation and each pool
used a different value.