Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get validation data from DB directly #717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 18, 2023

🧿 Current issues / What's wrong ?

The validation query on the hub is using data from space's cache.
This create refresh lag, and dependency on the space cache object.

💊 Fixes / Solution

Use a SQL query to get validations data from the database

🚧 Changes

  • Get validations data from the database

🛠️ Tests

  • Query some validation data from graphql => it should return same results as before

@wa0x6e wa0x6e requested a review from ChaituVR October 18, 2023 06:42
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6021043) 0.00% compared to head (7e3abdd) 0.00%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #717   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          40      40           
  Lines        1998    2005    +7     
  Branches       40      40           
======================================
- Misses       1958    1965    +7     
  Partials       40      40           
Files Coverage Δ
src/graphql/operations/validations.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wa0x6e wa0x6e added this to the Remove space cache milestone Oct 19, 2023
@wa0x6e
Copy link
Contributor Author

wa0x6e commented Nov 6, 2023

Pretty fast query, taking around 300ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant