feat: add a function to find unnamed arguments #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaehnemann
changed the title
dlaehnemann
changed the title
|
I just edited the title to conform to conventional commits, that we use to automate releases and changelogs via release-please. I guess this should be documented somewhere prominently, maybe in a pull request template... |
johanneskoester
requested changes
Nov 10, 2023
| _get_unnamed_arguments(snakemake.input) | ||
|
|
||
| """ | ||
| keys_with_positions = parameter_list._names |
There was a problem hiding this comment.
I don't like that this uses private attibutes of NamedList. I think the functionality should rather be directly implemented in NamedList. Can you please file a PR in the main Snakemake repository?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was quite usefull in snakemake/snakemake-wrappers#1322
I would like to make a new general wrapper where it will also be useful.
I hope it will not change with snakemake v8