-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shopping cart update (APPS-779 -> 782) #183
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shopping cart class is now migrated to kotlin. In this process the package structur has been adjusted, the code base has been cleaned up to make it more safe and some classes have been converted to data classes.
The shopping cart updater class is now migrated to kotlin. The code base has been cleaned up to make it more safe.
… modifier to give the user the option to manipulate the screen behaviour (e.g. like setting the background)
cmaier
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tough! 💪
Well done! 👏
It's quite a journey!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
As base for some new UI adjustements the shopping cart including classes associated with the cart are converted and migrated to kotlin. In this process some refactorings were done.
The Ui were refactored so that we can now display discounts, deposits and other stuff more distinct in the shopping cart instead of displaying on big discount item showing the total amount.
The following changes have been made:
Apps-781 -> coupons can now be activated and deactivated on the coupons details page. The coupons are not displayed as part of the cart anymore and can only be added/deactivated via the details screen.
Apps-779 -> discount referring to the whole card are now display as seperate single item.
Apps-780 / Apps-782- > discounts referring to a product are now displayed below it if all the required details. If multiply discounts are added, they will bne displayd as a list below the product.
Apps-806 -> the give away item type and all the referring logic has been removed.
The changes and the ui have been rewritten in compose so the old recycler view accountable for the cart has been removed and should be replaced with the new composable screen.
How to test?
Apps-781
Vino delizioso 3for2
to the cart and switch then back to the scanner.Bonner Spätburgunder
to tha cartApps-779
Apps-780 / Apps-782
Braeburn Rot
(Enter 1 into the searchbar and select the first item) and enter a weight + a manuall discount the the dialog showing upSnabble Pils Sixpack
to the cart. Enter 321 into the searchbar and add theBonner Spätburgunder
to the cart.Snabble Pils Sixpack
Definition of Done
App Tests
Testing