Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopping cart update (APPS-779 -> 782) #183

Merged
merged 59 commits into from
Jul 15, 2024
Merged

Shopping cart update (APPS-779 -> 782) #183

merged 59 commits into from
Jul 15, 2024

Conversation

Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented May 6, 2024

What's new?

As base for some new UI adjustements the shopping cart including classes associated with the cart are converted and migrated to kotlin. In this process some refactorings were done.

The Ui were refactored so that we can now display discounts, deposits and other stuff more distinct in the shopping cart instead of displaying on big discount item showing the total amount.

The following changes have been made:

Apps-781 -> coupons can now be activated and deactivated on the coupons details page. The coupons are not displayed as part of the cart anymore and can only be added/deactivated via the details screen.
Apps-779 -> discount referring to the whole card are now display as seperate single item.
Apps-780 / Apps-782- > discounts referring to a product are now displayed below it if all the required details. If multiply discounts are added, they will bne displayd as a list below the product.
Apps-806 -> the give away item type and all the referring logic has been removed.

The changes and the ui have been rewritten in compose so the old recycler view accountable for the cart has been removed and should be replaced with the new composable screen.

How to test?

Apps-781

  • Add the coupon for Vino delizioso 3for2 to the cart and switch then back to the scanner.
  • The coupon should not be displayed as part of the list
  • Enter 321 in the barcode search and add 3 items of Bonner Spätburgunder to tha cart
  • The coupon should be displayed as discount with discription below the item
  • The prices are displayed as expected
  • Remove the coupon on the details page and switch back to the scanner
  • The coupon is removed from the card and the prices are adjusted

Apps-779

  • Keep the item from bevore in the cart and simply increase the amount until u reach a price above 50 euro (or use any other item instead)
  • A cart discount should be displayed at the bottom of the cart
  • The prices are displayed as expected

Apps-780 / Apps-782

  • Select Braeburn Rot (Enter 1 into the searchbar and select the first item) and enter a weight + a manuall discount the the dialog showing up
  • The discount is displayed below the item and the prices are displayed as expected
  • Enter 4008 into the searchbar and add the Snabble Pils Sixpack to the cart. Enter 321 into the searchbar and add the Bonner Spätburgunder to the cart.
  • a group coupon is added and displayed below the Snabble Pils Sixpack
  • The deposit iand the prices are displayed as expected

Definition of Done

  • Changelog gepflegt
  • Dokumentation gepflegt
  • Alle Anforderung des Issues sind erfüllt
  • Selbst greviewed (aka Self-Reviews (eng))
  • Review mit Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified getestet? (aka. Release Build)
  • Environements beachtet (Production/Staging)
  • Unterstützte Sprachen sind getestet
  • Light-/Dark-Mode getestet
  • Edge-Cases getestet
  • Android API Levels wurden berücksichtigt (minSdk?)

Testing

  • Tests geschrieben (aka Unit-Tests, Integration-Tests)
  • Tests lokal laufen gelassen

@cmaier cmaier changed the title Shopping cart update(#145) Shopping cart update Jul 8, 2024
@cmaier cmaier changed the title Shopping cart update Shopping cart update (APPS-779 -> APPS-782) Jul 8, 2024
@cmaier cmaier changed the title Shopping cart update (APPS-779 -> APPS-782) Shopping cart update (APPS-779 -> 782) Jul 8, 2024
@cmaier cmaier self-requested a review July 9, 2024 06:28
@Fabtron Fabtron marked this pull request as ready for review July 15, 2024 05:09
Copy link
Contributor

@cmaier cmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tough! 💪
Well done! 👏
It's quite a journey!

@Fabtron Fabtron merged commit 8b2660d into main Jul 15, 2024
1 check passed
@Fabtron Fabtron deleted the feature-shopping-cart branch July 23, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants