Fixed string_shuffle function for unicode characters.

smuuf · Jul 13, 2019 · 10ad8d6 · 10ad8d6
1 parent 64a1d5a
commit 10ad8d6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/extensions/psl/StringExtension.php b/src/extensions/psl/StringExtension.php
@@ -15,7 +15,20 @@
 class StringExtension extends Extension {
 
 	public static function string_shuffle(StringValue $str): StringValue {
-		return new StringValue(str_shuffle((string) $str->value));
+
+		// str_shuffle() doesn't work with unicode, so let's do this ourselves.
+		$original = $str->value;
+		$length = mb_strlen($original);
+		$indices = range(0, $length - 1);
+		shuffle($indices);
+		$result = "";
+
+		while (($i = array_pop($indices)) !== null) {
+			$result .= mb_substr($original, $i, 1);
+		}
+
+		return new StringValue($result);
+
 	}
 
 	public static function string_length(StringValue $str): NumberValue {

diff --git a/tests/unit/value.string.phpt b/tests/unit/value.string.phpt
@@ -252,6 +252,13 @@ Assert::same(2, get_val($fns['string_number_of']->invoke([$string, new StringVal
 Assert::same(0, get_val($fns['string_number_of']->invoke([$string, new StringValue("xoxoxo")])));
 Assert::same(0, get_val($fns['string_number_of']->invoke([$string, new NumberValue(1)])));
 
+//
+// Test shuffle.
+//
+
+Assert::same(17, mb_strlen(get_val($fns['string_shuffle']->invoke([$string]))));
+Assert::same(17, mb_strlen(get_val($fns['string_shuffle']->invoke([$unicode]))));
+
 //
 // Test length.
 //