fix(ndisc): prevent ndisc when medium is IP. #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `medium-ip` feature, and `medium-ethernet` or `medium-ieee802154` is enabled, it was possible to receive an ICMP NDISC message. This made smoltcp panic as it tried to conver the HardwareAddress::Ip to a RawHardwareAddress.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
+ Coverage 79.62% 79.63% +0.01%
==========================================
Files 78 78
Lines 28043 28051 +8
==========================================
+ Hits 22329 22339 +10
+ Misses 5714 5712 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
medium-ipfeature, andmedium-ethernetormedium-ieee802154is enabled, it was possible to receive an ICMP NDISC message. This made smoltcp panic as it tried to conver the HardwareAddress::Ip to a RawHardwareAddress.