medium-ip does not compile complaining of needing EthernetAddress #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `'a` lifetime in the `Device` trait is essentially a workaround for lack of GATs. I'm just experimenting how this would look like, it'll have to wait until GATs are stable to go in. The main benefit is structs implementing `Device` can now borrow stuff. This wasn't possible before because the `for<'d> T: Device<'d>` bounds would essentially imply `T: 'static`.
|
can you add the feature combination that previously failed here so that it doesn't break again in the future? Thanks! |
|
@Dirbaio thx, I have added the combination to the workflow |
|
Also @Dirbaio now that rust 1.65 is released, would you be merging this to main and releasing an official version with this change ? |
Dirbaio
force-pushed
the
gat-device
branch
3 times, most recently
from
b92fc8f to
13cc7f8
Compare
|
It seems you've accidentally rebased on top of an old version of #572, could you remove the unrelated commits? |
|
oh, the issue was you opened this against the GAT branch. Please open all PRs against master. Rebased it for you at #706 |
bors bot
added a commit
that referenced
this pull request
Nov 6, 2022
706: Fix medium-ip not compiling complaining of needing EthernetAddress r=Dirbaio a=Dirbaio #703 rebased cc `@gopakumarce` Co-authored-by: Gopa Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure in question seems to be used only for ipv4 fragmentation, hence marking it the same