Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for wasm by disabling io primitives #91

Closed
wants to merge 6 commits into from

Conversation

notgull
Copy link
Member

@notgull notgull commented Sep 7, 2022

Resolves #89. There are now two features, enabled by default: io and timer. io enables the Async type and timer enables the Timer type. A different reactor is selected depending on which system we're using. When both features are disabled, the implementation of block_on is changed to be a brief wrapper around futures_lite's version of it.

This is a breaking change.

@notgull notgull changed the title Split the crate into io and timer features Enable support for wasm by disabling io primitives Sep 8, 2022
@notgull
Copy link
Member Author

notgull commented Sep 8, 2022

I rebased on master, implemented the changes I made in #92 in this branch, and reimplemented the new system such that it only exposes the fallback when compiled for target_family = "wasm"

@taiki-e
Copy link
Collaborator

taiki-e commented Oct 25, 2022

(Some code still refers feature = "io"...)

Cargo.toml Outdated Show resolved Hide resolved
@notgull
Copy link
Member Author

notgull commented Nov 27, 2022

This PR has gotten stale, I'll make a new one for the current state.

@notgull notgull closed this Nov 27, 2022
@notgull notgull deleted the split-feature branch November 27, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Enable usage of timers on WASM
2 participants