Fix dimming bug - Make dimming apply to whole window including last line #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myarcana
force-pushed
the
sanitize-cols
branch
from
fe4ea25 to
4b9eda4
Compare
myarcana
changed the title
myarcana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two typo-induced bugs in
sanitize_cols, so the bottom line of dimmed windows often wouldn't be dimmed.vim.api.nvim_buf_get_linesreturns a list, not the line itselfThe line number parameters to
vim.api.nvim_buf_get_linesare 0-indexed, butLineRangenumbers are 1-indexed