Add motion_forcing to Hop. #65 #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives users an easy way to customize how motions work with operators. You can force the motion to act linewise, charwise, or blockwise. The default tries to match how Neovim's handles the f/t/F/T operators.
|
Looks like Github decided to display issue 65 from the original repo instead of this one. Here's a link to the issue I'm actually trying to fix #65 |
myarcana
reviewed
Dec 22, 2024
lua/hop/init.lua
Outdated
| vim.cmd('normal! v') | ||
| elseif opts.direction == hint.HintDirection.BEFORE_CURSOR then | ||
| -- This lines up with how the F and T motions work | ||
| vim.cmd('normal! <C-V>') |
There was a problem hiding this comment.
Won't this break if hopping to a previous line? Shouldn't it also just be normal! v?
There was a problem hiding this comment.
It seems like blockwise was doing the right thing, but I don't really understand why. What I really wanted was for the motion to be exclusive which happens to be default, so I've updated the code to remove this elseif.
The original commit made backwards hopping blockwise. Although that did the right thing, it doesn't really make sense. What we really want is for the motion to be exclusive. I've updated the code and docs to make it exclusive instead of blockwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives users an easy way to customize how motions work with operators. You can force the motion to act linewise, charwise, or blockwise. The default tries to match how Neovim's handles the f/t/F/T operators.