Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust query string parameter tests for servers #857

Merged
merged 1 commit into from
Jul 14, 2021
+4 −4
Merged

Adjust query string parameter tests for servers #857

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions smithy-aws-protocol-tests/model/restJson1/http-query.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ apply AllQueryStringTypes @httpRequestTests([
"QueryParamsStringKeyB=Bar",
],
params: {
queryParamsMapOfStrings: {
"QueryParamsStringKeyA": "Foo",
"QueryParamsStringKeyB": "Bar",
queryParamsMapOfStringList: {
"QueryParamsStringKeyA": ["Foo"],
"QueryParamsStringKeyB": ["Bar"],
Comment on lines +108 to +110
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should have this test, but why do we need to get rid of the old one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @httpQueryParams is on a member, it has to be on a map of lists if any other @httpQuery member can have multiple values. So this isn't really about removing or adding tests, it's about making this test compatible with servers.

},
}
},
Expand Down Expand Up @@ -232,7 +232,7 @@ structure AllQueryStringTypesInput {
queryEnumList: FooEnumList,

@httpQueryParams
queryParamsMapOfStrings: StringMap,
queryParamsMapOfStringList: StringListMap,
}

/// This example uses a constant query string parameters and a label.
Expand Down