Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xmlns issues in awsQuery tests #799

Merged
merged 1 commit into from
May 13, 2021
Merged

Fix xmlns issues in awsQuery tests #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions smithy-aws-protocol-tests/model/awsQuery/xml-structs.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ apply XmlNamespaces @httpResponseTests([
protocol: awsQuery,
code: 200,
body: """
<XmlNamespacesResponse xmlns="http://foo.com" xmlns="https://example.com/">
<XmlNamespacesResponse xmlns="https://example.com/">
<XmlNamespacesResult>
<nested>
<foo xmlns:baz="http://baz.com">Foo</foo>
Expand Down Expand Up @@ -436,7 +436,7 @@ structure XmlNamespacesOutput {
}

// Ingored since it's not at the top-level
@xmlNamespace(uri: "http://foo.com")
@xmlNamespace(uri: "http://boo.com")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to show distinction from the also ignored @xmlNamespace trait on XmlNamespacesOutput.

structure XmlNamespaceNested {
@xmlNamespace(uri: "http://baz.com", prefix: "baz")
foo: String,
Expand Down Expand Up @@ -465,7 +465,7 @@ apply IgnoresWrappingXmlName @httpResponseTests([
protocol: awsQuery,
code: 200,
body: """
<IgnoresWrappingXmlNameResponse xmlns="http://foo.com" xmlns="https://example.com/">
<IgnoresWrappingXmlNameResponse xmlns="https://example.com/">
<IgnoresWrappingXmlNameResult>
<foo>bar</foo>
</IgnoresWrappingXmlNameResult>
Expand Down