Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample xml to match structure name for test. #757

Merged
merged 1 commit into from
Apr 2, 2021

Conversation

kggilmer
Copy link
Contributor

@kggilmer kggilmer commented Apr 2, 2021

Issue #, if available: N/A

Description of changes:

  • Update text Xml to match structure name
  • It's expected that this will enable the test to pass if protocol implementation is compiliant

Response from @kstich from internal discussion:

It's possible, would need to validate by updating and running another SDK's tests. I think others might not be validating the name of the root node for the response when deserializing.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kstich kstich merged commit bd301f8 into main Apr 2, 2021
@mtdowling mtdowling deleted the fix-restxml-ignorequeryparamsinresponse branch April 21, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants