Convert options to text #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONVERT_TO_TEXT is necessary on OPTIONS request otherwise you may see 500 errors from API Gateway. Further, this commit cleans up several getters/setters on the IntegrationTrait and MockIntegrationTrait to match what a code generator would produce and how the NodeMapper works.
This commit updates API Gateway traits to use the NodeMapper and changes different getter/setter methods to use NodeMapper compatible API names. Further, support for omitting the toNode implementation of a class was added so that the NodeMapper can be used inside of a toNode method. Finally, support for omitting empty arrays and objects was added so the NodeMapper doesn't inject a bunch of empty values when it isn't desirable.
mtdowling
commented
Apr 14, 2020
...-traits/src/main/java/software/amazon/smithy/aws/apigateway/traits/AuthorizerDefinition.java
Show resolved
Hide resolved
kstich
approved these changes
Apr 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use NodeMapper in API Gateway traits
Add CONVERT_TO_TEXT to OPTIONS and cleanup