Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate build logic to conventions plugins #2484

Merged
merged 7 commits into from
Dec 10, 2024
Merged

Migrate build logic to conventions plugins #2484

merged 7 commits into from
Dec 10, 2024

Conversation

haydenbaker
Copy link
Contributor

Background

  • Overhauls our builds to use convention plugins, which is a far cleaner approach
  • Spotless and formatting will be added/applied in a follow-up PR (separate to keep this PR from being several pages)

Testing

  • ./gradlew clean build publish -c -Plog-tests
  • tested jreleaser configs (for main and cli release)
  • checked shadowed publications, verified shadowed deps are not in the pom

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haydenbaker haydenbaker requested a review from a team as a code owner December 9, 2024 21:22
@haydenbaker haydenbaker changed the title Haydenbaker/add build plugins Migrate build logic to conventions plugins Dec 9, 2024
hpmellema
hpmellema requested changes Dec 10, 2024
View reviewed changes
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
buildSrc/src/main/kotlin/smithy.module-conventions.gradle.kts Outdated Show resolved Hide resolved
smithy-cli/build.gradle.kts Outdated Show resolved Hide resolved
@haydenbaker haydenbaker merged commit 1fdb522 into main Dec 10, 2024
14 checks passed
@haydenbaker haydenbaker mentioned this pull request Dec 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasmewad yasmewad yasmewad left review comments

@hpmellema hpmellema hpmellema approved these changes

@yefrig yefrig Awaiting requested review from yefrig yefrig is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haydenbaker @hpmellema @yasmewad