Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct case for aggregate shapes in table #2271

Merged
merged 1 commit into from
May 2, 2024

Conversation

gosar
Copy link
Contributor

@gosar gosar commented May 2, 2024

Background

Updates the table in https://smithy.io/2.0/spec/model.html#shape-types for Aggregate types to use the casing of the actual shape names, like list instead of List.

Note, this doesn't change the heading on the page https://smithy.io/2.0/spec/aggregate-types.html#list which is still List. We could consider changing the headings to match the shape name too, like for simple types, though we use uppercase for service types. Additional to this PR, if we want to change the headings to match the shape name, can do that separately.

Testing

cd docs
make install
make html
open build/html/2.0/index.html

Ran above and verified table has lower case in type column.

Links

  • Links to additional context, if necessary
  • Issue #, if applicable (see here for a list of keywords to use for linking issues)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gosar gosar requested a review from a team as a code owner May 2, 2024 16:02
@gosar gosar requested a review from milesziemer May 2, 2024 16:02
@kstich kstich merged commit e52e625 into smithy-lang:main May 2, 2024
13 checks passed
@gosar gosar deleted the agg-types-case branch May 2, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants