Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for StringArray rules engine Parameters #2266

Merged
merged 10 commits into from
May 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests and style
alextwoods committed Apr 30, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 796f14a391cd35bec49143970821d3b6bfb42177
Original file line number Diff line number Diff line change
@@ -53,7 +53,7 @@ private static boolean supportedType(Node node) {

if (node.isArrayNode()) {
// all elements must be strings
return node.expectArrayNode().getElements().stream().allMatch( e -> e.isStringNode());
return node.expectArrayNode().getElements().stream().allMatch(e -> e.isStringNode());
}

return false;
Original file line number Diff line number Diff line change
@@ -4,5 +4,5 @@ namespace smithy.example

use smithy.rules#staticContextParams

@staticContextParams(arrayParam: {value: ["foo", "bar"]})
@staticContextParams(arrayParam: {value: ["foo", 3]})
operation OperationArray {}