Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Smithy RPC v2 CBOR protocol tests #2188

Merged
merged 16 commits into from
Mar 22, 2024
Merged

Add Smithy RPC v2 CBOR protocol tests #2188

merged 16 commits into from
Mar 22, 2024

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Mar 13, 2024

Background

  • What do these changes do?
    Add protocol tests for Smithy RPC v2 CBOR.
  • Why are they important?
    Enable protocol compliance testing for the protocol.

Testing

  • How did you test these changes?
    Validation in SDK implementations.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kstich kstich requested a review from a team as a code owner March 13, 2024 18:19
@kstich kstich requested a review from JordonPhillips March 13, 2024 18:19
@kstich kstich mentioned this pull request Mar 13, 2024
Closed
lucix-aws
lucix-aws approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@lucix-aws lucix-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passing in Go v2.

kstich
kstich commented Mar 22, 2024
View reviewed changes
Copy link
Contributor Author

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add tags the tests that have definite/indefinite encodings so implementations that can't support one or the other for some reason can handle them.

smithy-aws-protocol-tests/model/rpcV2/cbor-lists.smithy Show resolved Hide resolved
smithy-aws-protocol-tests/model/rpcV2/cbor-structs.smithy Show resolved Hide resolved
smithy-aws-protocol-tests/model/rpcV2/cbor-structs.smithy Outdated Show resolved Hide resolved
@lucix-aws
Copy link
Contributor

Passing in go v2

@kstich kstich merged commit 80d5cbb into smithy-rpc-v2 Mar 22, 2024
11 checks passed
@kstich kstich deleted the smithy-rpc-v2-tests branch March 22, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drganjoo drganjoo drganjoo left review comments

@lucix-aws lucix-aws lucix-aws approved these changes

@JordonPhillips JordonPhillips Awaiting requested review from JordonPhillips JordonPhillips is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kstich @lucix-aws @drganjoo @adwsingh