Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle dependency error for publishing to maven local #2181

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

hpmellema
Copy link
Contributor

Background

* What went wrong:
A problem was found with the configuration of task ':smithy-aws-protocol-tests:sourcesJar' (type 'Jar').
  - Gradle detected a problem with the following location: '/Users/example/code/smithy/smithy-aws-protocol-tests/build/tmp/staging-smithyJarStaging'.
    
    Reason: Task ':smithy-aws-protocol-tests:sourcesJar' uses this output of task ':smithy-aws-protocol-tests:smithyJarStaging' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
    
    Possible solutions:
      1. Declare task ':smithy-aws-protocol-tests:smithyJarStaging' as an input of ':smithy-aws-protocol-tests:sourcesJar'.
      2. Declare an explicit dependency on ':smithy-aws-protocol-tests:smithyJarStaging' from ':smithy-aws-protocol-tests:sourcesJar' using Task#dependsOn.
      3. Declare an explicit dependency on ':smithy-aws-protocol-tests:smithyJarStaging' from ':smithy-aws-protocol-tests:sourcesJar' using Task#mustRunAfter.

Testing

  • Successfully ran ./gradlew publishToMavenLocal

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner March 12, 2024 19:01
@hpmellema hpmellema requested a review from haydenbaker March 12, 2024 19:01
@hpmellema hpmellema merged commit ec62a12 into smithy-lang:main Mar 12, 2024
13 checks passed
@hpmellema hpmellema deleted the add-missing-gradle-dependson branch March 12, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants