-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 0.5.0 IDL and AST format #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
deprecate-shape-index
branch
from
November 25, 2019 18:33
9481be1
to
767e9f0
Compare
mtdowling
force-pushed
the
add-0_5_0-format
branch
from
November 25, 2019 18:40
e9f92bb
to
5a00ef2
Compare
mtdowling
force-pushed
the
deprecate-shape-index
branch
from
November 25, 2019 18:50
767e9f0
to
9d9831a
Compare
mtdowling
force-pushed
the
add-0_5_0-format
branch
from
November 25, 2019 18:56
5a00ef2
to
63e2b66
Compare
mtdowling
force-pushed
the
add-0_5_0-format
branch
from
November 26, 2019 17:09
63e2b66
to
29bb322
Compare
mtdowling
force-pushed
the
add-0_5_0-format
branch
from
December 4, 2019 06:08
29bb322
to
7379fb2
Compare
mtdowling
force-pushed
the
add-0_5_0-format
branch
2 times, most recently
from
December 10, 2019 18:32
db77f29
to
12785e3
Compare
kstich
reviewed
Dec 11, 2019
...raits/src/test/resources/software/amazon/smithy/aws/traits/iam/invalid-condition-keys.smithy
Show resolved
Hide resolved
- Remove onVersion since LoaderVisitor is version independent - Simplify ModelLoader and use InputStream. This commit simplifies ModelLoader to be a single class with static methods rather than a series of internal-only ModelLoader interfaces. Further, it converts model loading to using InputStreams rather than Strings so that files can be parsed and streamed directly from their source rather than first loaded into a string and then into a Model. We should follow up on this by making the SmithyModelLexer streaming too. - Update specification for 0.5.0 IDL
mtdowling
force-pushed
the
add-0_5_0-format
branch
from
December 12, 2019 00:47
7d3ea04
to
f37dedb
Compare
This has been updated to include the AST, IDL, and protocol compliance tests. It's a rebase of those features and squashed into single commits for each. Nothing new here. |
kstich
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #189
Description of changes:
This commit adds support for version 0.5.0 of the AST. This makes loading and parsing the AST model much simpler and more approachable for other languages and tools like grep.
A TON of stuff has been changed in this PR. Lots of the changes were done using ad-hoc scripts I wrote to migrate from the old JSON AST to the new one (including scripts used to migrate the RST example). I looked at each RST example carefully, but they should still be double-checked. Test files were updated until they worked, so I'm confident that their right, but could use a very cursory glance at best.
Things to really look for:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.