Improve deprecation of IAM Action traits #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpmellema
reviewed
Jan 10, 2024
...aws-iam-traits/src/main/java/software/amazon/smithy/aws/iam/traits/RequiredActionsTrait.java
Outdated
Show resolved
Hide resolved
hpmellema
reviewed
Jan 10, 2024
smithy-aws-iam-traits/src/main/java/software/amazon/smithy/aws/iam/traits/ActionNameTrait.java
Outdated
Show resolved
Hide resolved
hpmellema
reviewed
Jan 10, 2024
This commit formally deprecates the traits superseded by `@iamAction` in Java code. Methods are added to IamAction to aid users in the resolution of properties. A resolution aid is also added to IamResource.
1. Layout to match PARC order 2. Tidy the condition key traits layout 3. Update to use myservice instead of otherservice for condition keys, as condition keys should reference the same service.
kstich
force-pushed
the
improve_iam_trait_deprecation
branch
from
c018959 to
3127144
Compare
hpmellema
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit formally deprecates the traits superseded by
@iamActionin Java code. Methods are added to IamAction to aid users in the
resolution of properties.
A resolution aid is also added to IamResource.
Update IAM trait documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.