Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol tests for 0/false in query params #2070

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions smithy-aws-protocol-tests/model/restJson1/http-query.smithy
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,22 @@ apply AllQueryStringTypes @httpRequestTests([
}
}
},
{
id: "RestJsonZeroAndFalseQueryValues"
documentation: "Query values of 0 and false are serialized"
protocol: restJson1
method: "GET"
uri: "/AllQueryStringTypesInput"
body: ""
queryParams: [
"Integer=0"
"Boolean=false"
]
params: {
queryInteger: 0
queryBoolean: false
}
}
])

@suppress(["HttpQueryParamsTrait"])
Expand Down
16 changes: 16 additions & 0 deletions smithy-aws-protocol-tests/model/restXml/http-query.smithy
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,22 @@ apply AllQueryStringTypes @httpRequestTests([
queryDouble: "-Infinity",
}
},
{
id: "RestXmlZeroAndFalseQueryValues"
documentation: "Query values of 0 and false are serialized"
protocol: restXml
method: "GET"
uri: "/AllQueryStringTypesInput"
body: ""
queryParams: [
"Integer=0"
"Boolean=false"
]
params: {
queryInteger: 0
queryBoolean: false
}
}
])

@suppress(["HttpQueryParamsTrait"])
Expand Down