Add @aws.auth#sigv4a trait
#2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
add-sigv4a-trait
branch
5 times, most recently
from
1fdfc3f to
0db1716
Compare
milesziemer
requested changes
Dec 5, 2023
...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/auth/SigV4TraitsValidator.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
add-sigv4a-trait
branch
from
0db1716 to
7ffc0a0
Compare
JordonPhillips
requested changes
Dec 5, 2023
...hy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/auth/SigV4TraitsValidator.java
Outdated
Show resolved
Hide resolved
smithy-aws-traits/src/main/resources/META-INF/smithy/aws.auth.smithy
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
add-sigv4a-trait
branch
from
7ffc0a0 to
7d8ca63
Compare
milesziemer
approved these changes
Dec 5, 2023
JordonPhillips
approved these changes
Dec 5, 2023
rchache
pushed a commit
to rchache/smithy
that referenced
this pull request
Jan 2, 2024
* Add `@aws.auth#sigv4a` trait * Add `@aws.auth#sigv4a` trait Java implementation * Add `SigV4TraitsValidator` validation * Add `@aws.auth#sigv4a` trait tests * Add `@aws.auth#sigv4a` trait documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
This PR adds the
@aws.auth#sigv4atrait implementation, documentation, and additional validation of the trait respective to the@aws.auth#sigv4and@aws.api#servicetraits.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.