Add automatic integration configuration #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a configuration step for integrations, allowing them to use `smithy-build.json` settings that aren't used by the generator that they target. Generators using the node mapper helper for their settings will have this set for free. Others will need to grab it themselves.
JordonPhillips
force-pushed
the
configure-integrations
branch
from
63a48db to
389eb37
Compare
haydenbaker
approved these changes
Oct 20, 2023
mtdowling
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration step for integrations, allowing them to use
smithy-build.jsonsettings that aren't used by the generator that they target.Generators using the node mapper helper for their settings will have this set for free. Others will need to grab it themselves.
FAQ
Why not just have integration drive configuration through traits
Yes that's the ideal but some things just don't make sense as traits. For example, a trait that controls whether a documentation generator scans your system for the presence of a build tool and all the other dependencies you need doesn't make sense as a trait.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.