Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix member timestamp format node validation #1948

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

mtdowling
Copy link
Member

The NodeValidationVisitor vists shapes, members, and then the targets of members. When visiting the target of a member, the context of the referring member was lost, which meant a member with a timestampFormat trait like http-date isn't something the target shape has access to, which will cause validation to fail. We now pass in the referring member as part of the validation context.

Closes #1946

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mtdowling mtdowling requested a review from a team as a code owner August 24, 2023 20:16
The NodeValidationVisitor vists shapes, members, and then the targets
of members. When visiting the target of a member, the context of the
referring member was lost, which meant a member with a timestampFormat
trait like http-date isn't something the target shape has access to,
which will cause validation to fail. We now pass in the referring
member as part of the validation context.

Closes #1946
@mtdowling mtdowling force-pushed the fix-timestamp-format-traits branch from 1071e8e to 9aa3e73 Compare August 24, 2023 20:23
@mtdowling mtdowling merged commit 302ace8 into main Aug 24, 2023
@srchase srchase deleted the fix-timestamp-format-traits branch August 24, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants