Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating specific tree types #1925

Merged
merged 1 commit into from
Aug 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,27 @@ static TokenTree of(IdlTokenizer tokenizer) {
return capturingTokenizer.getRoot();
}

/**
* Create a TokenTree of the given {@link TreeType} from an {@link IdlTokenizer}.
*
mtdowling marked this conversation as resolved.
Show resolved Hide resolved
* <p>The following example shows how to create a {@link TokenTree} for a trait.</p>
*
* <pre>{@code
* IdlTokenizer tokenizer = IdlTokenizer.create("@someTrait");
* TokenTree traitTree = TokenTree.of(tokenizer, TreeType.TRAIT);
* }</pre>
*
* @param tokenizer Tokenizer to traverse.
* @param type Type of tree to create.
* @return Returns the created tree.
*/
static TokenTree of(IdlTokenizer tokenizer, TreeType type) {
CapturingTokenizer capturingTokenizer = new CapturingTokenizer(tokenizer);
type.parse(capturingTokenizer);
// The root of the tree is always IDL with children appended, so the first child is the one we want.
return capturingTokenizer.getRoot().getChildren().get(0);
}

/**
* Create a leaf tree from a single token.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@ public void createsFromTokenizer() {
assertThat(tree.getChildren().get(2).getType(), equalTo(TreeType.SHAPE_SECTION));
}

@Test
public void createsFromTokenizerAndType() {
IdlTokenizer tokenizer = IdlTokenizer.create("@foo");
TokenTree tree = TokenTree.of(tokenizer, TreeType.TRAIT);

assertThat(tree.getType(), is(TreeType.TRAIT));
assertThat(tree.getChildren(), hasSize(2));
assertThat(tree.getError(), nullValue());
assertThat(tree.getChildren().get(0).getType(), equalTo(TreeType.TOKEN));
assertThat(tree.getChildren().get(1).getType(), equalTo(TreeType.SHAPE_ID));
}

@Test
public void createsFromCapturedToken() {
IdlTokenizer tokenizer = IdlTokenizer.create("foo");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1860,9 +1860,7 @@ private static void assertTreeIsInvalid(TokenTree tree) {
}

private static TokenTree getTree(TreeType type, String forText) {
CapturingTokenizer tokenizer = new CapturingTokenizer(IdlTokenizer.create(forText));
type.parse(tokenizer);
// The root of the tree is always IDL with children appended, so the first child is the one we want.
return tokenizer.getRoot().getChildren().get(0);
IdlTokenizer tokenizer = IdlTokenizer.create(forText);
return TokenTree.of(tokenizer, type);
}
}