Skip to content

Add noErrorWrapping protocol test for restXml #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2023
Merged

Add noErrorWrapping protocol test for restXml #1574

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9794fb3
Add noErrorWrapping protocol test for restXml
jvschneid Jan 9, 2023
fd84e6e
Move noErrorWrapping test into error shape
jvschneid Jan 9, 2023
d9598b1
Merge branch 'awslabs:main' into rest-xml-no-error-wrapping-protocol-…
jvschneid Jun 7, 2023
376e0f1
Merge branch 'awslabs:main' into rest-xml-no-error-wrapping-protocol-…
jvschneid Jun 15, 2023
519d040
Merge branch 'smithy-lang:main' into rest-xml-no-error-wrapping-proto…
jvschneid Jul 21, 2023
3b2ef4e
Merge branch 'smithy-lang:main' into rest-xml-no-error-wrapping-proto…
jvschneid Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions smithy-aws-protocol-tests/model/restXml/services/s3.smithy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,22 @@ structure DeleteObjectTaggingOutput {
VersionId: ObjectVersionId
}

@httpResponseTests([
{
id: "S3OperationNoErrorWrappingResponse",
documentation: """
S3 operations return Error XML nodes unwrapped by
the ErrorResponse XML node.
""",
protocol: restXml,
code: 400,
headers: {
"Content-Type": "application/xml"
},
body: "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error>\n\t<Type>Sender</Type>\n\t<Code>NoSuchBucket</Code>\n</Error>",
bodyMediaType: "application/xml",
}
])
@error("client")
structure NoSuchBucket {}

Expand Down