Warn on unknown trait diffs #1468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In smithy-diff, traits that have `diff` tags applied to their definitions can be properly evaluated on modification. However, it is possible for models to be loaded without trait definitions, meaning no diff evaluation occurs. This commit updates the ModifiedTrait evaluator to emit events when a trait without a definition is not constant across the compared models.
AndrewFossAWS
approved these changes
Oct 25, 2022
syall
approved these changes
Oct 25, 2022
mtdowling
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In smithy-diff, traits that have
difftags applied to their definitions can be properly evaluated on modification. However, it is possible for models to be loaded without trait definitions, meaning no diff evaluation occurs. This commit updates the ModifiedTrait evaluator to emit events when a trait without a definition is not constant across the compared models.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.