Update identifier ABNF and parser #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
requested changes
Oct 24, 2022
smithy-model/src/main/java/software/amazon/smithy/model/shapes/ShapeId.java
Outdated
Show resolved
Hide resolved
Previously, the ABNF did not match the identifier parser. This commit updates the ABNF to match current parsing behavior, and updates the identifier parser to avoid out of bounds exceptions. Also, a set of tests are added for ONLY parsing identifiers rather than being mixed with namespace tests.
syall
force-pushed
the
identifier-abnf-update
branch
from
4ae41af to
843fe69
Compare
mtdowling
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Previously, the ABNF did not match the identifier parser.
This commit updates the ABNF to match current parsing behavior, and updates the identifier parser to avoid out of bounds exceptions.
Also, a set of tests are added for ONLY parsing identifiers rather than being mixed with namespace tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.