Fix a log message for unable to convert string enum to enum shape #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the case where the enum trait does not have names and synthesizeEnumNames
is false.
There is no functional difference with this change, however a more specific and appropriate log message will be used for case where names aren't defined in the enum trait (i.e., they would need to be synthesized) but the synthesizeEnumNames is set to false.
Testing
Without the EnumShape.java change in this PR, the newly added canConvertToEnumWithNamelessEnumTrait test case for
assertFalse(EnumShape.canConvertToEnum(string, false));
would logWith the change, the test case now logs the more appropriate log for this use case
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.