Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect warning for service errors property #1120

Merged
merged 2 commits into from
Mar 4, 2022
+5 −5
Merged

Fix incorrect warning for service errors property #1120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f088e6
Fix incorrect warning for service errors property
adamthom-amzn Mar 3, 2022
1931bfb
Fix nondeterministic unit test
adamthom-amzn Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix nondeterministic unit test
@adamthom-amzn
adamthom-amzn committed Mar 4, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 1931bfbeddb5b88b70e9adc4ea761b16834e11f2
2 changes: 1 addition & 1 deletion smithy-build/src/test/java/software/amazon/smithy/build/SmithyBuildTest.java
View file
Original file line number Diff line number Diff line change
@@ -638,7 +638,7 @@ public void projectionsThatCannotCreateModelsFailGracefully() throws URISyntaxEx
assertTrue(result.anyBroken());

// Now validate that we got the failure to serialize the model.
List<ValidationEvent> events = result.getProjectionResults().get(0).getEvents();
List<ValidationEvent> events = result.getProjectionResultsMap().get("foo").getEvents();
assertThat(events, not(empty()));
assertThat(events.get(0).getSeverity(), is(Severity.ERROR));
assertThat(events.get(0).getMessage(), containsString("Unable to serialize trait"));