CodeGuru Reviewer Action with improved error handling #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
December 3, 2021 17:29
|
Can you squash these commits when it's ready to merge? |
Sure. It's ready now. Whenever you guys approve, I'll squash |
adamthom-amzn
approved these changes
Dec 8, 2021
|
Actually, I'm not allowed to merge @adamthom-amzn can you do the squash? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The action that was added in #1000 had the limitation that it failed on Pull Requests if the person triggering the PR did not have permission to assume the IAM role to access CodeGuru (see failure).
To make the Action more convenient, we make it fail softly if the role cannot be assumed. The action will still be triggered after every Squash Merge by this repository where it has permission to assume the role.
Example of running the action without permissions 1.
and with permissions 2.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.