Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test RestJsonMalformedPatternReDOSString is broken #1506

Closed
jjant opened this issue Nov 21, 2022 · 1 comment · Fixed by #1959
Closed

Test RestJsonMalformedPatternReDOSString is broken #1506

jjant opened this issue Nov 21, 2022 · 1 comment · Fixed by #1959
Labels
bug This issue is a bug. protocol-test New protocol tests are needed

Comments

@jjant
Copy link
Contributor

jjant commented Nov 21, 2022 •
edited
Loading

This test is broken in several ways:

  • It uses $value but there's no testParameters
  • The path is wrong: '/string' should be '/evilString'
  • The regex in the error message is wrong, it should be ^([0-9]+)+$
@jjant jjant changed the title Wrong regular expression in malformed test's error message Test RestJsonMalformedPatternReDOSString is broken Nov 21, 2022
@jjant
Copy link
Contributor Author

jjant commented Nov 21, 2022

I've implemented a fix for this in smithy-rs here.

@srchase srchase added the protocol-test New protocol tests are needed label Dec 30, 2022
@mtdowling mtdowling added the bug This issue is a bug. label Aug 25, 2023
@kstich kstich mentioned this issue Aug 29, 2023
Merged
david-perez added a commit to david-perez/smithy that referenced this issue Jun 28, 2024
@david-perez
Fix RestJsonMalformedPatternReDOSString test
6b55583 
The test was incorrectly fixed as part of smithy-lang#1506.
david-perez added a commit to david-perez/smithy that referenced this issue Jun 28, 2024
@david-perez
Fix RestJsonMalformedPatternReDOSString test
88ed303 
The test was attempted to be fixed as part of smithy-lang#1506. None of the other
tests echo back the value that failed the regex.
@david-perez david-perez mentioned this issue Jun 28, 2024
Merged
kstich pushed a commit that referenced this issue Jul 1, 2024
@david-perez @kstich
Fix RestJsonMalformedPatternReDOSString test
efcb39c 
The test was attempted to be fixed as part of #1506. None of the other
tests echo back the value that failed the regex.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. protocol-test New protocol tests are needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ReDOS malformed request test kstich/smithy
3 participants
@mtdowling @srchase @jjant